OpenSystemsDevelopment / qpdf

Commit 064a90da2d256ef07c359273c234eb56c4f72f0d

Authored by Jay Berkenbilt
1 parent b83a6524

TODO: update cmake notes

Inline Side-by-side
Showing 1 changed file with 11 additions and 5 deletions
... ... @@ -103,11 +103,17 @@ cmake
103 103  
104 104 * Rebase the cmake branch onto main and fast-forward over it.
105 105 * Remove all "lt-" workarounds.
106   -* Change name of DLL_EXPORT preprocessor symbol passed into the build.
107   - Be sure to call attention to this in the release notes. There should
108   - be a "migrating to cmake" in the manual, and ./configure should draw
109   - attention to it.
110   -* Remove DLL.h and QPDF_DLL from all private library classes.
  106 +* DLL.h
  107 + * Remove DLL.h and QPDF_DLL* from all private library classes.
  108 + * Change DLL_EXPORT to QPDF_EXPORT. Be sure to call attention to
  109 + this in the release notes. There should be a "migrating to cmake"
  110 + in the manual, and ./configure should draw attention to it.
  111 + * Remove the definition of QPDF_DLL_CLASS from DLL.h and change all
  112 + occurrences of QPDF_DLL_CLASS to QPDF_DLL. This will require
  113 + removing QPDF_DLL from methods inside classes that are declared
  114 + with QPDF_DLL. If we want to explicit exclude private methods, we
  115 + will need to mark them as not exported. See
  116 + https://gcc.gnu.org/wiki/Visibility
111 117 * Nice to have:
112 118 * Split qpdf.test into multiple tests
113 119 * Rework tests so that nothing is written into the source directory.
... ...