Fix isPagesObject and isPageObject

There are lots of things with /Kids that are not pages. Repair the pages tree, then do a reliable check.

Fix isPagesObject and isPageObject
There are lots of things with /Kids that are not pages. Repair the pages tree, then do a reliable check.
Jay Berkenbilt
1 parent 3aefdd18
Showing 1 changed file with 16 additions and 2 deletions
libqpdf/QPDFObjectHandle.cc
@@ -3039,6 +3039,12 @@ bool
 QPDFObjectHandle::isPageObject()
 {
     // See comments in QPDFObjectHandle.hh.
+    if (getOwningQPDF() == nullptr)
+    {
+        return false;
+    }
+    // getAllPages repairs /Type when traversing the page tree.
+    getOwningQPDF()->getAllPages();
     if (! this->isDictionary())
     {
         return false;
@@ -3066,8 +3072,16 @@ QPDFObjectHandle::isPageObject()
 bool
 QPDFObjectHandle::isPagesObject()
 {
-    // Some PDF files have /Type broken on pages.
-    return (this->isDictionary() && this->hasKey("/Kids"));
+    if (getOwningQPDF() == nullptr)
+    {
+        return false;
+    }
+    // getAllPages repairs /Type when traversing the page tree.
+    getOwningQPDF()->getAllPages();
+    return (this->isDictionary() &&
+            this->hasKey("/Type") &&
+            this->getKey("/Type").isName() &&
+            this->getKey("/Type").getName() == "/Pages");
 }
 bool