diff --git a/src/modbus-data.c b/src/modbus-data.c index c0505b3..99f4838 100644 --- a/src/modbus-data.c +++ b/src/modbus-data.c @@ -59,25 +59,25 @@ static inline uint32_t bswap_32(uint32_t x) /* Sets many bits from a single byte value (all 8 bits of the byte value are set) */ -void modbus_set_bits_from_byte(uint8_t *dest, int index, const uint8_t value) +void modbus_set_bits_from_byte(uint8_t *dest, int idx, const uint8_t value) { int i; for (i=0; i < 8; i++) { - dest[index+i] = (value & (1 << i)) ? 1 : 0; + dest[idx+i] = (value & (1 << i)) ? 1 : 0; } } -/* Sets many bits from a table of bytes (only the bits between index and - index + nb_bits are set) */ -void modbus_set_bits_from_bytes(uint8_t *dest, int index, unsigned int nb_bits, +/* Sets many bits from a table of bytes (only the bits between idx and + idx + nb_bits are set) */ +void modbus_set_bits_from_bytes(uint8_t *dest, int idx, unsigned int nb_bits, const uint8_t *tab_byte) { unsigned int i; int shift = 0; - for (i = index; i < index + nb_bits; i++) { - dest[i] = tab_byte[(i - index) / 8] & (1 << shift) ? 1 : 0; + for (i = idx; i < idx + nb_bits; i++) { + dest[i] = tab_byte[(i - idx) / 8] & (1 << shift) ? 1 : 0; /* gcc doesn't like: shift = (++shift) % 8; */ shift++; shift %= 8; @@ -86,7 +86,7 @@ void modbus_set_bits_from_bytes(uint8_t *dest, int index, unsigned int nb_bits, /* Gets the byte value from many bits. To obtain a full byte, set nb_bits to 8. */ -uint8_t modbus_get_byte_from_bits(const uint8_t *src, int index, +uint8_t modbus_get_byte_from_bits(const uint8_t *src, int idx, unsigned int nb_bits) { unsigned int i; @@ -99,7 +99,7 @@ uint8_t modbus_get_byte_from_bits(const uint8_t *src, int index, } for (i=0; i < nb_bits; i++) { - value |= (src[index+i] << i); + value |= (src[idx+i] << i); } return value; diff --git a/src/modbus.h b/src/modbus.h index e14607c..1fb3591 100644 --- a/src/modbus.h +++ b/src/modbus.h @@ -222,10 +222,10 @@ MODBUS_API int modbus_reply_exception(modbus_t *ctx, const uint8_t *req, tab_int8[(index) + 1] = (value) & 0xFF; \ } while (0) -MODBUS_API void modbus_set_bits_from_byte(uint8_t *dest, int index, const uint8_t value); -MODBUS_API void modbus_set_bits_from_bytes(uint8_t *dest, int index, unsigned int nb_bits, +MODBUS_API void modbus_set_bits_from_byte(uint8_t *dest, int idx, const uint8_t value); +MODBUS_API void modbus_set_bits_from_bytes(uint8_t *dest, int idx, unsigned int nb_bits, const uint8_t *tab_byte); -MODBUS_API uint8_t modbus_get_byte_from_bits(const uint8_t *src, int index, unsigned int nb_bits); +MODBUS_API uint8_t modbus_get_byte_from_bits(const uint8_t *src, int idx, unsigned int nb_bits); MODBUS_API float modbus_get_float(const uint16_t *src); MODBUS_API float modbus_get_float_dcba(const uint16_t *src); MODBUS_API void modbus_set_float(float f, uint16_t *dest);