From 9ffbf54284aceb720ac479829a0bcfc0ba0c6e1a Mon Sep 17 00:00:00 2001
From: Neil Blakey-Milner <nbm@knowledgetree.com>
Date: Fri, 26 May 2006 13:12:39 +0000
Subject: [PATCH] Check session verification against boolean true using type checking.

---
 login.php | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/login.php b/login.php
index 4404a17..b76c013 100644
--- a/login.php
+++ b/login.php
@@ -41,7 +41,8 @@ class LoginPageDispatcher extends KTDispatcher {
     function check() {
         $oKTConfig = KTConfig::getSingleton();
         $this->session = new Session();
-        if ($this->session->verify() == 1) { // the session is valid
+        $sessionStatus = $this->session->verify();
+        if ($sessionStatus === true) { // the session is valid
             if ($_SESSION['userID'] == -2 && $oKTConfig->get('allowAnonymousLogin', false)) {
                 ; // that's ok - we want to login.
             }
@@ -54,7 +55,8 @@ class LoginPageDispatcher extends KTDispatcher {
 
     function do_providerVerify() {
         $this->session = new Session();
-        if ($this->session->verify() != 1) {
+        $sessionStatus = $this->session->verify();
+        if ($sessionStatus !== true) { // the session is not valid
             $this->redirectToMain();
         }
         $this->oUser =& User::get($_SESSION['userID']);
@@ -164,7 +166,7 @@ class LoginPageDispatcher extends KTDispatcher {
         $_SESSION["pageAccess"] = NULL; 
 
         $cookietest = KTUtil::randomString();
-        setcookie("CookieTestCookie", $cookietest, false);
+        setcookie("CookieTestCookie", $cookietest, 0);
 
         $this->redirectTo('checkCookie', array(
             'cookieVerify' => $cookietest,
--
libgit2 0.21.4