From 6f03fa976169823d381be2e0f492e150420aade6 Mon Sep 17 00:00:00 2001
From: bshuttle <bshuttle@c91229c3-7414-0410-bfa2-8a42b809f60b>
Date: Fri, 3 Feb 2006 14:54:39 +0000
Subject: [PATCH] - fix a ... very annoying bug in firefox (return false) handling. - don't duplicate javascript.

---
 resources/js/kt-utility.js                   | 31 +++++++++++++++++++++++--------
 templates/ktcore/principals/useradmin.smarty |  3 +--
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/resources/js/kt-utility.js b/resources/js/kt-utility.js
index 675c8fe..498a13f 100644
--- a/resources/js/kt-utility.js
+++ b/resources/js/kt-utility.js
@@ -2,15 +2,29 @@
  * general utility functions for KT
  */
 
-function addEvent(obj, event, func) {
+var message;
+
+function addEvent(obj, event, func, capture) {
     if (obj.attachEvent) { obj.attachEvent('on'+event, func); }
-   else { obj.addEventListener(event, func, false); }
+    else { obj.addEventListener(event, func, capture); }
 }
 
-function confirmDelete(message) { return confirm(message); } 
+function confirmDelete(e) { 
+    var v =  confirm(message); 
+    if (v == false) {
+        if (e.stopPropagation) {
+            e.stopPropagation();
+            e.preventDefault();
+        }
+        else if (window.event)
+            return false;
+    }
+    return v; 
+} 
  
-function initDeleteProtection(message) {
-    var fn = partial(confirmDelete, message);
+function initDeleteProtection(m) {
+    var fn = confirmDelete;
+    message = m;
     var elements = getElementsByTagAndClassName('A','ktDelete');
 
     function setClickFunction(fn, node) {
@@ -21,13 +35,14 @@ function initDeleteProtection(message) {
             else { return null; }
         }
 
-        addEvent(node, 'click', fn);
+        addEvent(node, 'click', fn, true);
+        
     }
     
     forEach(elements, partial(setClickFunction, fn));
     
-    elements = getElementsByTagAndClassName('SPAN', 'ktDelete');
+    //elements = getElementsByTagAndClassName('SPAN', 'ktDelete');
     
-    forEach(elements, partial(setClickFunction, fn));
+    //forEach(elements, partial(setClickFunction, fn));
     
 }
\ No newline at end of file
diff --git a/templates/ktcore/principals/useradmin.smarty b/templates/ktcore/principals/useradmin.smarty
index c0d8f95..7c53821 100644
--- a/templates/ktcore/principals/useradmin.smarty
+++ b/templates/ktcore/principals/useradmin.smarty
@@ -53,8 +53,7 @@ very slow if you have many users).{/i18n}</p>
         <td>{$oUser->getName()}</td>
         <td>{$oUser->getUsername()}</td>
         <td><a href="{addQS}action=editUser&user_id={$oUser->getId()}{/addQS}" class="ktAction ktEdit">{i18n}Edit{/i18n}</a></td>
-        <td><a onclick="javascript:return confirm('{i18n}Are you sure
-you wish to delete this user?{/i18n}');" href="{addQS}action=deleteuser&user_id={$oUser->getId()}{/addQS}" class="ktAction ktDelete">{i18n}Delete{/i18n}</a></td>
+        <td><a href="{addQS}action=deleteuser&user_id={$oUser->getId()}{/addQS}" class="ktAction ktDelete">{i18n}Delete{/i18n}</a></td>
         <td><a href="{addQS}action=editgroups&user_id={$oUser->getId()}{/addQS}">{i18n}Groups{/i18n}</a></td>  
      </tr>   
      {/foreach}
--
libgit2 0.21.4