diff --git a/templates/ktcore/document/add.smarty b/templates/ktcore/document/add.smarty index 6b0b39b..480676b 100644 --- a/templates/ktcore/document/add.smarty +++ b/templates/ktcore/document/add.smarty @@ -14,29 +14,31 @@ {capture assign=sJavascript} {literal} function swapInItem(elementId, req) { - var cp = getElement(elementId); - cp.innerHTML = req.responseText; initialiseConditionalFieldsets(); } function xmlFailure(err) { - alert('failed'); + ; // bad me - fail silently. +} + +function handleErrorsInResponse(req) { + ; // bad me - fail silently. } function swapElementFromRequest(elementId, url) { var deff = doSimpleXMLHttpRequest(url); - deff.addCallback(partial(swapInItem, elementId)); + var cp = getElement(elementId); cp.innerHTML="loading..."; + deff.addCallback(partial(swapInItem, elementId)); + deff.addErrback(handleErrorsInResponse); } function getMetadataForType(id) { - swapElementFromRequest('type_metadata_fields', - '{/literal}{$rootUrl}{literal}/presentation/lookAndFeel/knowledgeTree/documentmanagement/getTypeMetadataFields.php?fDocumentTypeID=' - + id); + swapElementFromRequest('type_metadata_fields', '{/literal}{$rootUrl}{literal}/presentation/lookAndFeel/knowledgeTree/documentmanagement/getTypeMetadataFields.php?fDocumentTypeID=' + id); } function document_type_changed() { diff --git a/templates/ktcore/folder/bulkImport.smarty b/templates/ktcore/folder/bulkImport.smarty index 1daf80f..01483f3 100644 --- a/templates/ktcore/folder/bulkImport.smarty +++ b/templates/ktcore/folder/bulkImport.smarty @@ -25,9 +25,10 @@ function xmlFailure(err) { function swapElementFromRequest(elementId, url) { var deff = doSimpleXMLHttpRequest(url); - deff.addCallback(partial(swapInItem, elementId)); var cp = getElement(elementId); cp.innerHTML="loading..."; + deff.addCallback(partial(swapInItem, elementId)); + } diff --git a/templates/ktcore/folder/bulkUpload.smarty b/templates/ktcore/folder/bulkUpload.smarty index 8da7499..fbd39f6 100644 --- a/templates/ktcore/folder/bulkUpload.smarty +++ b/templates/ktcore/folder/bulkUpload.smarty @@ -25,9 +25,10 @@ function xmlFailure(err) { function swapElementFromRequest(elementId, url) { var deff = doSimpleXMLHttpRequest(url); - deff.addCallback(partial(swapInItem, elementId)); var cp = getElement(elementId); cp.innerHTML="loading..."; + deff.addCallback(partial(swapInItem, elementId)); + }