From 2a36f7ae02e6c5033f23053da69d2f39a87a590b Mon Sep 17 00:00:00 2001
From: nbm <nbm@c91229c3-7414-0410-bfa2-8a42b809f60b>
Date: Fri, 9 Jun 2006 18:06:57 +0000
Subject: [PATCH] Return PEAR_Error objects when given non-numeric ids with get.

---
 lib/documentmanagement/Document.inc | 4 +++-
 lib/ktentity.inc                    | 5 ++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/documentmanagement/Document.inc b/lib/documentmanagement/Document.inc
index 3b044c9..9cbdf8e 100644
--- a/lib/documentmanagement/Document.inc
+++ b/lib/documentmanagement/Document.inc
@@ -199,9 +199,11 @@ class Document {
 
     // {{{ get
     function &get($iId, $iMetadataVersion=null) {
+        if (!is_numeric($iId)) {
+            return PEAR::raiseError(_('Non-numeric identifier'));
+        }
         $iId = (int)$iId;
         $oDocument = new Document();
-        // if (!is_numeric($iId)) { print "<pre>Document.inc: 162: "; var_dump($iId); print "</pre>"; }
         $res = $oDocument->load($iId, $iMetadataVersion);
         if (PEAR::isError($res)) { 
             return $res;
diff --git a/lib/ktentity.inc b/lib/ktentity.inc
index 84963fe..7178440 100644
--- a/lib/ktentity.inc
+++ b/lib/ktentity.inc
@@ -628,8 +628,11 @@ class KTEntityUtil {
     }
 
     function &get($sClassName, $iId) {
-        /* */
+        if (!is_numeric($iId)) {
+            return PEAR::raiseError(_('Non-numeric identifier'));
+        }
         $iId = (int)$iId;
+        /* */
         $sProxyClass = KTEntityUtil::_getProxyClass($sClassName);
         $oObject =& new $sProxyClass($iId);
         $res = $oObject->getId();
--
libgit2 0.21.4