diff --git a/i18n/knowledgeTree.pot b/i18n/knowledgeTree.pot index 8678783..1f89190 100644 --- a/i18n/knowledgeTree.pot +++ b/i18n/knowledgeTree.pot @@ -10551,7 +10551,7 @@ msgid "the user who did the check-out is not currently available to check it bac msgstr "" #: i18n/templates.c:1061 i18n/templates.c:1067 i18n/templates.c:1088 -msgid "this cannot not change between versions" +msgid "this cannot change between versions" msgstr "" #: i18n/templates.c:1022 diff --git a/plugins/ktcore/KTDocumentActions.php b/plugins/ktcore/KTDocumentActions.php index 32fb262..f1be637 100644 --- a/plugins/ktcore/KTDocumentActions.php +++ b/plugins/ktcore/KTDocumentActions.php @@ -182,6 +182,7 @@ class KTDocumentVersionHistoryAction extends KTDocumentAction { $QS = array( 'action' => 'viewComparison', 'fDocumentId' => $this->oDocument->getId(), + 'fBaseVersion' => $_REQUEST['fBaseVersion'], 'fComparisonVersion' => $_REQUEST['fComparisonVersion'], ); diff --git a/plugins/ktstandard/KTDiscussion.php b/plugins/ktstandard/KTDiscussion.php index 3e69b53..a7d4cfa 100644 --- a/plugins/ktstandard/KTDiscussion.php +++ b/plugins/ktstandard/KTDiscussion.php @@ -177,8 +177,8 @@ class KTDocumentDiscussionAction extends KTDocumentAction { $oComment = DiscussionComment::createFromArray(array( 'threadid' => $oThread->getId(), 'userid' => $this->oUser->getId(), - 'subject' => sanitize($sSubject), - 'body' => sanitize(KTUtil::formatPlainText($sBody)), + 'subject' => sanitizeForSQL($sSubject), + 'body' => sanitizeForSQL(KTUtil::formatPlainText($sBody)), )); $aErrorOptions['message'] = _kt("There was an error adding the comment to the thread"); $this->oValidator->notError($oComment, $aErrorOptions); @@ -306,8 +306,8 @@ class KTDocumentDiscussionAction extends KTDocumentAction { $oComment = DiscussionComment::createFromArray(array( 'threadid' => $oThread->getId(), 'userid' => $this->oUser->getId(), - 'subject' => sanitize($sSubject), - 'body' => sanitize(KTUtil::formatPlainText($sBody)), + 'subject' => sanitizeForSQL($sSubject), + 'body' => sanitizeForSQL(KTUtil::formatPlainText($sBody)), )); $aErrorOptions['message'] = _kt("There was an error adding the comment to the thread"); $this->oValidator->notError($oComment, $aErrorOptions); @@ -387,7 +387,7 @@ class KTDocumentDiscussionAction extends KTDocumentAction { } $aErrorOptions['message'] = _kt("No reason provided"); - $sReason = sanitize($this->oValidator->validateString(KTUtil::arrayGet($_REQUEST, 'reason'), $aErrorOptions)); + $sReason = sanitizeForSQL($this->oValidator->validateString(KTUtil::arrayGet($_REQUEST, 'reason'), $aErrorOptions)); if($iStateId > $oThread->getState()) { $sTransactionNamespace = 'ktcore.transactions.collaboration_step_approve'; diff --git a/search/simpleSearch.php b/search/simpleSearch.php index 6e19389..ca06c90 100644 --- a/search/simpleSearch.php +++ b/search/simpleSearch.php @@ -142,7 +142,7 @@ class SimpleSearchDispatcher extends KTStandardDispatcher { $aErrorOptions = array( "message" => _kt("Please provide a search term"), ); - $searchable_text = sanitize(KTUtil::arrayGet($_REQUEST, "fSearchableText")); + $searchable_text = sanitizeForSQL(KTUtil::arrayGet($_REQUEST, "fSearchableText")); $this->oValidator->notEmpty($searchable_text, $aErrorOptions); diff --git a/templates/kt3/fieldsets/generic_versioned.smarty b/templates/kt3/fieldsets/generic_versioned.smarty index 88c7385..ee9e780 100644 --- a/templates/kt3/fieldsets/generic_versioned.smarty +++ b/templates/kt3/fieldsets/generic_versioned.smarty @@ -41,12 +41,12 @@ {i18n}Created by{/i18n} - {$creator} ({$creation_date}) ({i18n}this cannot not change between versions{/i18n}) + {$creator} ({$creation_date}) ({i18n}this cannot change between versions{/i18n}) {i18n}Owned by{/i18n} - {$owner} ({i18n}this cannot not change between versions{/i18n}) + {$owner} ({i18n}this cannot change between versions{/i18n}) {capture assign="oldval"}{$comparison_last_modified_by} ({$comparison_last_modified_date}){/capture} @@ -83,7 +83,7 @@ {i18n}Document ID{/i18n} - {$document->getId()} ({i18n}this cannot not change between versions{/i18n}) + {$document->getId()} ({i18n}this cannot change between versions{/i18n}) diff --git a/view.php b/view.php index 28ad9e4..290f0d5 100755 --- a/view.php +++ b/view.php @@ -95,12 +95,12 @@ class ViewDocumentDispatcher extends KTStandardDispatcher { function do_main() { // fix legacy, broken items. if (KTUtil::arrayGet($_REQUEST, "fDocumentID", true) !== true) { - $_REQUEST["fDocumentId"] = sanitize(KTUtil::arrayGet($_REQUEST, "fDocumentID")); + $_REQUEST["fDocumentId"] = sanitizeForSQL(KTUtil::arrayGet($_REQUEST, "fDocumentID")); unset($_REQUEST["fDocumentID"]); } $document_data = array(); - $document_id = sanitize(KTUtil::arrayGet($_REQUEST, 'fDocumentId')); + $document_id = sanitizeForSQL(KTUtil::arrayGet($_REQUEST, 'fDocumentId')); if ($document_id === null) { $this->oPage->addError(sprintf(_kt("No document was requested. Please browse for one."), KTBrowseUtil::getBrowseBaseUrl())); return $this->do_error(); @@ -252,7 +252,7 @@ class ViewDocumentDispatcher extends KTStandardDispatcher { function do_viewComparison() { $document_data = array(); - $document_id = sanitize(KTUtil::arrayGet($_REQUEST, 'fDocumentId')); + $document_id = sanitizeForSQL(KTUtil::arrayGet($_REQUEST, 'fDocumentId')); if ($document_id === null) { $this->oPage->addError(sprintf(_kt("No document was requested. Please browse for one."), KTBrowseUtil::getBrowseBaseUrl())); return $this->do_error(); @@ -260,7 +260,7 @@ class ViewDocumentDispatcher extends KTStandardDispatcher { $document_data["document_id"] = $document_id; - $base_version = sanitize(KTUtil::arrayGet($_REQUEST, 'fBaseVersion')); + $base_version = sanitizeForSQL(KTUtil::arrayGet($_REQUEST, 'fBaseVersion')); // try get the document. $oDocument =& Document::get($document_id, $base_version); @@ -285,7 +285,7 @@ class ViewDocumentDispatcher extends KTStandardDispatcher { $this->aBreadcrumbs = array_merge($this->aBreadcrumbs, KTBrowseUtil::breadcrumbsForDocument($oDocument, $aOptions)); $this->oPage->setBreadcrumbDetails(_kt("compare versions")); - $comparison_version = sanitize(KTUtil::arrayGet($_REQUEST, 'fComparisonVersion')); + $comparison_version = sanitizeForSQL(KTUtil::arrayGet($_REQUEST, 'fComparisonVersion')); if ($comparison_version=== null) { $this->oPage->addError(sprintf(_kt("No comparison version was requested. Please select a version."), KTUtil::addQueryStringSelf('action=history&fDocumentId=' . $document_id))); return $this->do_error();