From 1be51fb526fe8a000ce5b1844edcd72f6257baea Mon Sep 17 00:00:00 2001
From: nbm <nbm@c91229c3-7414-0410-bfa2-8a42b809f60b>
Date: Thu, 15 Sep 2005 09:48:39 +0000
Subject: [PATCH] Fix which functions return references and those that don't, and fix a minor type around the orderby option to getList.

---
 lib/ktentity.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/ktentity.inc b/lib/ktentity.inc
index 51509a8..9a1bcc2 100644
--- a/lib/ktentity.inc
+++ b/lib/ktentity.inc
@@ -156,7 +156,7 @@ class KTEntity {
         return true;
     }
 
-    function &_set (&$element, &$params) {
+    function _set (&$element, &$params) {
         $this->$element = $params;
         return array(true, true);
     }
@@ -259,7 +259,7 @@ class KTEntityUtil {
         }
         $sOrderBy = KTUtil::arrayGet($aOptions, 'orderby');
         if (!empty($sOrderBy)) {
-            $sQuery .= "ORDER BY " . $sOrderBy;
+            $sQuery .= " ORDER BY " . $sOrderBy;
         }
         $aIDs = DBUtil::getResultArrayKey(array($sQuery, $aParams), $sIDField);
 
@@ -274,7 +274,7 @@ class KTEntityUtil {
         return $aRet;
     }
 
-    function createFromArray ($sClassName, $aOptions) {
+    function &createFromArray ($sClassName, $aOptions) {
         $oObject = new $sClassName;
         $ret = $oObject->loadFromArray($aOptions);
         if (PEAR::isError($ret)) {
--
libgit2 0.21.4