From 0a9c27bfba0fd9101e8ed570a39e737bde81ffe4 Mon Sep 17 00:00:00 2001
From: bshuttle <bshuttle@c91229c3-7414-0410-bfa2-8a42b809f60b>
Date: Mon, 6 Mar 2006 08:12:34 +0000
Subject: [PATCH] fix for KTS-575 - groups->getUsers failed to prune errors.

---
 lib/groups/Group.inc              | 16 +++-------------
 lib/workflow/workflowutil.inc.php |  2 +-
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/lib/groups/Group.inc b/lib/groups/Group.inc
index 7ab397b..00c2d64 100644
--- a/lib/groups/Group.inc
+++ b/lib/groups/Group.inc
@@ -133,19 +133,9 @@ class Group extends KTEntity {
 	/**
 	 * Returns an array of Users in this group.
 	 */
-	function getUsers() {
-		global $default;
-		$sql = $default->db;
-		$result = $sql->query(array("SELECT user_id FROM $default->users_groups_table WHERE group_id = ?", $this->iId));/*ok*/
-		$aUsers = array();		
-		if ($result) {			
-			$iCount = 0;
-			while ($sql->next_record()) {
-				$oUser = & User::get($sql->f("user_id"));
-				$aUsers[$iCount++] = $oUser;
-			}
-		}
-		return $aUsers;		
+	function &getUsers() {
+	    // legacy api.
+		return $this->getMembers();		
 	}
 	
     function &getMembers() {
diff --git a/lib/workflow/workflowutil.inc.php b/lib/workflow/workflowutil.inc.php
index 85d89f1..9441e00 100644
--- a/lib/workflow/workflowutil.inc.php
+++ b/lib/workflow/workflowutil.inc.php
@@ -601,7 +601,7 @@ class KTWorkflowUtil {
         
         // now, merge this (again) into the user-set.
         foreach ($aGroups as $oGroup) {
-            $aNewUsers = $oGroup->getUsers();
+            $aNewUsers = $oGroup->getMembers();
             foreach ($aNewUsers as $oU) {
 			    $id = $oU->getId();
                 if (!array_key_exists($id, $aUsers)) {
--
libgit2 0.21.4