From 068215b8e1767dc9ec80f39b781baf622600aea1 Mon Sep 17 00:00:00 2001 From: Jan <33495614+Jojo-1000@users.noreply.github.com> Date: Thu, 7 May 2020 21:00:27 +0200 Subject: [PATCH] Apply documentation changes from code review --- include/hueplusplus/ResourceList.h | 10 +++++----- include/hueplusplus/Schedule.h | 2 +- src/APICache.cpp | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/hueplusplus/ResourceList.h b/include/hueplusplus/ResourceList.h index 4eebf20..47eee44 100644 --- a/include/hueplusplus/ResourceList.h +++ b/include/hueplusplus/ResourceList.h @@ -83,7 +83,7 @@ public: void refresh() { stateCache.refresh(); } //! \brief Get all resources that exist - //! \returns A vectory of references to every Resource + //! \returns A vector of references to every Resource //! \throws std::system_error when system or socket operations fail //! \throws HueException when response contains no body //! \throws HueAPIResponseException when response contains an error @@ -105,7 +105,7 @@ public: } //! \brief Get resource specified by id - //! \param id ID of the resource + //! \param id Identifier of the resource //! \returns The resource matching the id //! \throws std::system_error when system or socket operations fail //! \throws HueException when id does not exist @@ -129,7 +129,7 @@ public: } //! \brief Checks whether resource with id exists - //! \param id Id of the resource to check + //! \param id Identifier of the resource to check //! \returns true when the resource with given id exists //! \throws std::system_error when system or socket operations fail //! \throws HueException when response contains no body @@ -146,7 +146,7 @@ public: } //! \brief Checks whether resource with id exists - //! \param id Id of the resource to check + //! \param id Identifier of the resource to check //! \returns true when the resource with given id exists //! \note This will not update the cache //! \throws HueException when the cache is empty @@ -161,7 +161,7 @@ public: } //! \brief Removes the resource - //! \param id Id of the resource to remove + //! \param id Identifier of the resource to remove //! \returns true on success //! \throws std::system_error when system or socket operations fail //! \throws HueException when response contains no body diff --git a/include/hueplusplus/Schedule.h b/include/hueplusplus/Schedule.h index f5c6e43..17785bc 100644 --- a/include/hueplusplus/Schedule.h +++ b/include/hueplusplus/Schedule.h @@ -95,7 +95,7 @@ public: //! \throws nlohmann::json::parse_error when response could not be parsed void refresh(); - //! \brief Get schedule id + //! \brief Get schedule identifier int getId() const; //! \brief Get schedule name diff --git a/src/APICache.cpp b/src/APICache.cpp index 5b03074..347419c 100644 --- a/src/APICache.cpp +++ b/src/APICache.cpp @@ -151,6 +151,7 @@ bool APICache::needsRefresh() } return false; } + std::string APICache::getRequestPath() const { std::string result; -- libgit2 0.21.4