From f34d6038635f52dc9dd05f35a6bf95469b18abe0 Mon Sep 17 00:00:00 2001 From: Jarryd Beck Date: Mon, 8 Feb 2021 09:33:31 +1100 Subject: [PATCH] Fix missing override --- cmake/cxxopts.cmake | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmake/cxxopts.cmake b/cmake/cxxopts.cmake index e7307f5..8f9d61a 100644 --- a/cmake/cxxopts.cmake +++ b/cmake/cxxopts.cmake @@ -73,7 +73,11 @@ function(cxxopts_enable_warnings) if(MSVC) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W2") elseif(CMAKE_CXX_COMPILER_ID MATCHES "[Cc]lang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wextra -Wshadow -Weffc++ -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wno-sign-conversion") + if (CMAKE_CXX_COMPILER_ID MATCHES "GNU") + set(COMPILER_SPECIFIC_FLAGS "-Wsuggest-override") + endif() + + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wextra -Wshadow -Weffc++ -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wno-sign-conversion ${COMPILER_SPECIFIC_FLAGS}") endif() set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} PARENT_SCOPE) -- libgit2 0.21.4