From 6a66c78c37c3fe616e1eca63823d256e4a061169 Mon Sep 17 00:00:00 2001
From: Patric Stout <github@truebrain.nl>
Date: Mon, 17 Oct 2022 19:30:23 +0200
Subject: [PATCH] chore: apply some SonarCloud suggestions

---
 src/Client.cpp     | 6 ++----
 src/Connection.cpp | 4 ++--
 src/Connection.h   | 2 +-
 src/Packet.h       | 2 +-
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/Client.cpp b/src/Client.cpp
index 9b4601b..cbd7f5f 100644
--- a/src/Client.cpp
+++ b/src/Client.cpp
@@ -50,9 +50,7 @@ TrueMQTT::Client::Impl::Impl(const std::string_view host,
 {
 }
 
-TrueMQTT::Client::Impl::~Impl()
-{
-}
+TrueMQTT::Client::Impl::~Impl() = default;
 
 void TrueMQTT::Client::setLogger(Client::LogLevel log_level, const std::function<void(Client::LogLevel, std::string_view)> &logger) const
 {
@@ -211,7 +209,7 @@ void TrueMQTT::Client::subscribe(const std::string_view topic, const std::functi
     // Add the callback to the leaf node.
     subscriptions->callbacks.push_back(callback);
 
-    m_impl->m_subscription_topics.insert(std::string(topic));
+    m_impl->m_subscription_topics.emplace(topic);
     if (m_impl->m_state == Client::Impl::State::CONNECTED)
     {
         if (!m_impl->sendSubscribe(topic))
diff --git a/src/Connection.cpp b/src/Connection.cpp
index 875fb41..59d18b8 100644
--- a/src/Connection.cpp
+++ b/src/Connection.cpp
@@ -128,7 +128,7 @@ void TrueMQTT::Client::Impl::Connection::runRead()
 
 std::optional<Packet> TrueMQTT::Client::Impl::Connection::popSendQueueBlocking()
 {
-    std::unique_lock<std::mutex> lock(m_send_queue_mutex);
+    std::unique_lock lock(m_send_queue_mutex);
     if (!m_send_queue.empty())
     {
         auto packet = m_send_queue.front();
@@ -213,7 +213,7 @@ void TrueMQTT::Client::Impl::Connection::resolve()
     int error = getaddrinfo(m_impl.m_host.c_str(), std::to_string(m_impl.m_port).c_str(), &hints, &m_host_resolved);
     if (error != 0)
     {
-        m_impl.m_error_callback(TrueMQTT::Client::Error::HOSTNAME_LOOKUP_FAILED, std::string(gai_strerror(error)));
+        m_impl.m_error_callback(TrueMQTT::Client::Error::HOSTNAME_LOOKUP_FAILED, std::string_view(gai_strerror(error)));
         return;
     }
 
diff --git a/src/Connection.h b/src/Connection.h
index bace342..6b1a58c 100644
--- a/src/Connection.h
+++ b/src/Connection.h
@@ -29,7 +29,7 @@
 class TrueMQTT::Client::Impl::Connection
 {
 public:
-    Connection(TrueMQTT::Client::Impl &impl);
+    explicit Connection(TrueMQTT::Client::Impl &impl);
     ~Connection();
 
     bool send(Packet packet, bool has_priority = false);
diff --git a/src/Packet.h b/src/Packet.h
index 8039492..06b7caa 100644
--- a/src/Packet.h
+++ b/src/Packet.h
@@ -13,7 +13,7 @@
 class Packet
 {
 public:
-    enum class PacketType
+    enum class PacketType : uint8_t
     {
         CONNECT = 1,
         CONNACK = 2,
--
libgit2 0.21.4