From 819155b9510b981b2f9b0087f6b8c2e9bac65060 Mon Sep 17 00:00:00 2001 From: Geoffrey Hunter Date: Mon, 6 Dec 2021 14:05:57 +1300 Subject: [PATCH] Fixed a build error by changing the branch cmake downloads googletest from master to main. --- CHANGELOG.md | 8 ++++++++ CMakeLists.txt.in | 2 +- README.md | 10 +++++----- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d469f5d..80e1302 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). +## [v2.2.1] - 2021-12-06 + +- Fixed a build error by changing the branch cmake downloads googletest from master to main. + +## [v2.2.0] - 2021-12-03 + +- ReadBinary() and WriteBinary() added to read/write raw data, instead of having to use strings (thanks to @RolandHughes for adding this). + ## [v2.1.2] - 2021-07-01 - Removed download of gtest if tests are not built. diff --git a/CMakeLists.txt.in b/CMakeLists.txt.in index d60a33e..8003c2c 100644 --- a/CMakeLists.txt.in +++ b/CMakeLists.txt.in @@ -5,7 +5,7 @@ project(googletest-download NONE) include(ExternalProject) ExternalProject_Add(googletest GIT_REPOSITORY https://github.com/google/googletest.git - GIT_TAG master + GIT_TAG main SOURCE_DIR "${CMAKE_BINARY_DIR}/googletest-src" BINARY_DIR "${CMAKE_BINARY_DIR}/googletest-build" CONFIGURE_COMMAND "" diff --git a/README.md b/README.md index caea473..d3bc070 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Library for communicating with COM ports on a Linux system. * Simple API * Supports custom baud rates -* cmake based build system +* `cmake` based build system ## Installation @@ -51,13 +51,13 @@ Library for communicating with COM ports on a Linux system. $ sudo make install ``` -1. To run the unit tests (NOTE: because this uses virtual serial ports via `stty`, this only works on Linux!): +1. To run the unit tests: ```bash $ make run_unit_tests ``` - If you get errors such as `Could not open device /dev/ttyS10. Is the device name correct and do you have read/write permission?" thrown in the test fixture's constructor.`, it is probably an issue with either creating the virtual serial ports or permissions to access them. + NOTE: The unit tests used to use virtual serial ports via `stty` on Linux to do more through testing. I ran into permission problems running stty on TravisCI after they did an update and had to remove tests (leaving almost no tests remaining). If anyone wants to add better unit tests, it is greatly welcomed! ## Examples @@ -73,7 +73,7 @@ int main() { serialPort.SetTimeout(-1); // Block when reading until any data is received serialPort.Open(); - // Write some ASCII datae + // Write some ASCII data serialPort.Write("Hello"); // Read some data back (will block until at least 1 byte is received due to the SetTimeout(-1) call above) @@ -103,4 +103,4 @@ See GitHub Issues. ## Changelog -See CHANGELOG.md. \ No newline at end of file +See CHANGELOG.md. -- libgit2 0.21.4