From dadf8307c83706c3b097bc4b1fe7b24defbebb8e Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Tue, 27 Aug 2019 17:57:38 -0400 Subject: [PATCH] Fix fuzz issues 15316 and 15390 --- fuzz/qpdf_extra/15316.fuzz | 3 +++ fuzz/qpdf_extra/15390.fuzz | Bin 0 -> 821 bytes libqpdf/QPDF.cc | 6 ++++++ 3 files changed, 9 insertions(+), 0 deletions(-) create mode 100644 fuzz/qpdf_extra/15316.fuzz create mode 100644 fuzz/qpdf_extra/15390.fuzz diff --git a/fuzz/qpdf_extra/15316.fuzz b/fuzz/qpdf_extra/15316.fuzz new file mode 100644 index 0000000..0c29ddc --- /dev/null +++ b/fuzz/qpdf_extra/15316.fuzz @@ -0,0 +1,3 @@ + 1 0 obj<<2147483647 0 R>> +endobj +trailer<> \ No newline at end of file diff --git a/fuzz/qpdf_extra/15390.fuzz b/fuzz/qpdf_extra/15390.fuzz new file mode 100644 index 0000000..e8233c9 Binary files /dev/null and b/fuzz/qpdf_extra/15390.fuzz differ diff --git a/libqpdf/QPDF.cc b/libqpdf/QPDF.cc index f6d16e4..a774bd4 100644 --- a/libqpdf/QPDF.cc +++ b/libqpdf/QPDF.cc @@ -4,6 +4,7 @@ #include #include #include +#include #include #include #include @@ -2151,6 +2152,11 @@ QPDFObjectHandle QPDF::makeIndirectObject(QPDFObjectHandle oh) { int max_objid = toI(getObjectCount()); + if (max_objid == std::numeric_limits::max()) + { + throw std::range_error( + "max object id is too high to create new objects"); + } QPDFObjGen next(max_objid + 1, 0); this->m->obj_cache[next] = ObjCache(QPDFObjectHandle::ObjAccessor::getObject(oh), -1, -1); -- libgit2 0.21.4