From c5a627ff2fcc177ebeab8b90d115a6d24ad75f6d Mon Sep 17 00:00:00 2001 From: m-holger Date: Tue, 18 Nov 2025 00:11:59 +0000 Subject: [PATCH] Refactor: use local static variable for JSON schema in `initializeFromJson` and remove unused global variable `JOB_SCHEMA`. --- libqpdf/QPDFJob_json.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libqpdf/QPDFJob_json.cc b/libqpdf/QPDFJob_json.cc index 1684359..21d5e17 100644 --- a/libqpdf/QPDFJob_json.cc +++ b/libqpdf/QPDFJob_json.cc @@ -10,8 +10,6 @@ #include #include -static JSON JOB_SCHEMA = JSON::parse(QPDFJob::job_json_schema(1).c_str()); - namespace { class Handlers @@ -625,8 +623,9 @@ void QPDFJob::initializeFromJson(std::string const& json, bool partial) { std::list errors; + static const JSON schema = JSON::parse(job_json_schema(1).data()); JSON j = JSON::parse(json); - if (!j.checkSchema(JOB_SCHEMA, JSON::f_optional, errors)) { + if (!j.checkSchema(schema, JSON::f_optional, errors)) { std::ostringstream msg; msg << m->message_prefix << ": job json has errors:"; for (auto const& error: errors) { -- libgit2 0.21.4