From 92de83977fd2456a759e7beddb522c51d112a940 Mon Sep 17 00:00:00 2001
From: m-holger <m.holger@qpdf.org>
Date: Mon, 18 Aug 2025 14:38:28 +0100
Subject: [PATCH] Refactor `QPDFObjectHandle::arrayOrStreamToStreamArray`: replace `as_array` and bounds checks with subscript operator, simplify loop logic, and remove redundant trace.

---
 libqpdf/QPDFObjectHandle.cc | 3 +--
 qpdf/qpdf.testcov           | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc
index f0a37d6..af62923 100644
--- a/libqpdf/QPDFObjectHandle.cc
+++ b/libqpdf/QPDFObjectHandle.cc
@@ -1234,11 +1234,10 @@ QPDFObjectHandle::arrayOrStreamToStreamArray(
     if (auto array = as_array(strict)) {
         int n_items = static_cast<int>(array.size());
         for (int i = 0; i < n_items; ++i) {
-            QPDFObjectHandle item = array.at(i).second;
+            QPDFObjectHandle item = array[i];
             if (item.isStream()) {
                 result.emplace_back(item);
             } else {
-                QTC::TC("qpdf", "QPDFObjectHandle non-stream in stream array");
                 item.warn(
                     {qpdf_e_damaged_pdf,
                      "",
diff --git a/qpdf/qpdf.testcov b/qpdf/qpdf.testcov
index 237d052..5fc0d91 100644
--- a/qpdf/qpdf.testcov
+++ b/qpdf/qpdf.testcov
@@ -282,7 +282,6 @@ qpdf-c called qpdf_set_newline_before_endstream 0
 SF_FlateLzwDecode TIFF predictor 0
 QPDFTokenizer inline image at EOF 0
 Pl_QPDFTokenizer found ID 0
-QPDFObjectHandle non-stream in stream array 0
 QPDFObjectHandle coalesce called on stream 0
 QPDFObjectHandle coalesce provide stream data 0
 QPDF_Stream bad token at end during normalize 0
--
libgit2 0.21.4