From 54759cbf6399e53b421c4dbe3d3fc0cb1d655573 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Tue, 27 Oct 2020 18:07:07 -0400 Subject: [PATCH] Remove C++-11 notes from TODO --- TODO | 27 --------------------------- 1 file changed, 0 insertions(+), 27 deletions(-) diff --git a/TODO b/TODO index 29bb38a..e3ac99c 100644 --- a/TODO +++ b/TODO @@ -150,39 +150,12 @@ Other notes: way that works for the qpdf/qpdf repository as well since they are very similar. - ABI Changes =========== This is a list of changes to make next time there is an ABI change. Comments appear in the code prefixed by "ABI" -C++-11 -====== - -* Search for ::iterator and ::const_iterator and replace with either - auto or foreach-style iteration. - -* There may be some places where std::function and lambdas can - simplify handlers rather than using classes with apply methods. - -* My c++11 branch adds re-implements PointerHolder so that it is - interchangeable with std::shared_ptr. We may not actually want to - ever do this because it turns out PointerHolder is slightly more - performant than std::shared_ptr, at least as of g++ 9.2.1. It is not - actually possible to just replace PointerHolder with std::shared_ptr - for two reasons: there is no automatic creation of - std::shared_ptr from T* like there is for PointerHolder, which - breaks some code, and also there is no automatic conversion from - something like std::vector> to - std::vector>. It may be a good idea to replace - PointerHolder with std::shared_ptr in the API even if it requires - some work for the developer, but even if that isn't worth it, we - should find all occurrences of PointerHolder within the code and - replace with std::shared_ptr or std::unique_ptr as needed. This will - definitely break binary compatibility as the PointerHolder - pattern is part of the ABI for almost every class. - Page splitting/merging ====================== -- libgit2 0.21.4