From 52904a1cf364813f373a4ebb55c27bef7c37dd96 Mon Sep 17 00:00:00 2001
From: m-holger <m.holger@qpdf.org>
Date: Sun, 28 Sep 2025 18:17:45 +0100
Subject: [PATCH] Refactor `Buffer`: replace raw `new` with `std::make_unique` for safer and more modern resource management.

---
 libqpdf/Buffer.cc | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/libqpdf/Buffer.cc b/libqpdf/Buffer.cc
index 26041af..532ebd0 100644
--- a/libqpdf/Buffer.cc
+++ b/libqpdf/Buffer.cc
@@ -9,12 +9,12 @@ class Buffer::Members
     friend class Buffer;
 
   public:
-    ~Members();
-
-  private:
     Members(size_t size, unsigned char* buf, bool own_memory);
     Members(std::string&& content);
     Members(Members const&) = delete;
+    ~Members();
+
+  private:
 
     std::string str;
     bool own_memory;
@@ -50,27 +50,27 @@ Buffer::Members::~Members()
 }
 
 Buffer::Buffer() :
-    m(new Members(0, nullptr, true))
+    m(std::make_unique<Members>(0, nullptr, true))
 {
 }
 
 Buffer::Buffer(size_t size) :
-    m(new Members(size, nullptr, true))
+    m(std::make_unique<Members>(size, nullptr, true))
 {
 }
 
 Buffer::Buffer(std::string&& content) :
-    m(new Members(std::move(content)))
+    m(std::make_unique<Members>(std::move(content)))
 {
 }
 
 Buffer::Buffer(unsigned char* buf, size_t size) :
-    m(new Members(size, buf, false))
+    m(std::make_unique<Members>(size, buf, false))
 {
 }
 
 Buffer::Buffer(std::string& content) :
-    m(new Members(content.size(), reinterpret_cast<unsigned char*>(content.data()), false))
+    m(std::make_unique<Members>(content.size(), reinterpret_cast<unsigned char*>(content.data()), false))
 {
 }
 
@@ -92,7 +92,7 @@ void
 Buffer::copy(Buffer const& rhs)
 {
     if (this != &rhs) {
-        m = std::unique_ptr<Members>(new Members(rhs.m->size, nullptr, true));
+        m = std::make_unique<Members>(rhs.m->size, nullptr, true);
         if (m->size) {
             memcpy(m->buf, rhs.m->buf, m->size);
         }
--
libgit2 0.21.4