From 51b9e4196ea3159eade207cdab84c9b545aeef73 Mon Sep 17 00:00:00 2001 From: m-holger Date: Tue, 11 Feb 2025 14:18:45 +0000 Subject: [PATCH] Remove deprecated overload of QPDFObjectHandle::getJSON --- include/qpdf/QPDFObjectHandle.hh | 5 ----- libqpdf/QPDFObjectHandle.cc | 7 ------- manual/release-notes.rst | 3 +++ 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/include/qpdf/QPDFObjectHandle.hh b/include/qpdf/QPDFObjectHandle.hh index 147d508..80bd797 100644 --- a/include/qpdf/QPDFObjectHandle.hh +++ b/include/qpdf/QPDFObjectHandle.hh @@ -1206,11 +1206,6 @@ class QPDFObjectHandle void writeJSON( int json_version, Pipeline* p, bool dereference_indirect = false, size_t depth = 0) const; - // Deprecated version uses v1 for backward compatibility. - // ABI: remove for qpdf 12 - [[deprecated("Use getJSON(int version)")]] QPDF_DLL JSON - getJSON(bool dereference_indirect = false) const; - // This method can be called on a stream to get a more extended JSON representation of the // stream that includes the stream's data. The JSON object returned is always a dictionary whose // "dict" key is an encoding of the stream's dictionary. The representation of the data is diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc index b933641..6fd62f2 100644 --- a/libqpdf/QPDFObjectHandle.cc +++ b/libqpdf/QPDFObjectHandle.cc @@ -1615,13 +1615,6 @@ QPDFObjectHandle::unparseBinary() const } } -// Deprecated versionless getJSON to be removed in qpdf 12 -JSON -QPDFObjectHandle::getJSON(bool dereference_indirect) const -{ - return getJSON(1, dereference_indirect); -} - JSON QPDFObjectHandle::getJSON(int json_version, bool dereference_indirect) const { diff --git a/manual/release-notes.rst b/manual/release-notes.rst index fd55ac6..efc6e71 100644 --- a/manual/release-notes.rst +++ b/manual/release-notes.rst @@ -11,6 +11,9 @@ For a detailed list of changes, please see the file 12.0.0: not yet released - API: breaking changes + - Deprecated versionless overload of ``QPDFObjectHandle::getJSON`` + has been removed. + - ``Buffer`` copy constructor and assignment operator have been removed. ``Buffer`` copy operations are expensive as they always involve copying the buffer content. Use ``buffer2 = buffer1.copy();`` -- libgit2 0.21.4